[fix] trunk_ids Assignment Error in SIPDispatchRuleUpdate#468
Merged
davidzhao merged 1 commit intolivekit:mainfrom Jul 17, 2025
Merged
Conversation
Protobuf disallows direct assignment to message fields like after initialization, which was causing an AttributeError. This commit sets during SIPDispatchRuleUpdate construction using ListUpdate(set=...), ensuring proper serialization and avoiding runtime failure.
|
|
benhmill
changed the title
benhmill
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
LiveKit's SIPDispatchRuleUpdate is a protobuf message where fields like
trunk_idsmust be set during initialization.Problem
Attempting to assign
trunk_idsafter instantiation raised the following runtime error:AttributeError: Assignment not allowed to message, map, or repeated field "trunk_ids" in protocol message object.
This is due to protobuf’s restriction against direct assignment to message or repeated fields after construction.
Fix
Set
trunk_idsduring SIPDispatchRuleUpdate construction usingListUpdate(set=...), ensuring proper initialization and serialization by the protobuf engine.